Avoid collision with tinyusb hid.h enums #7463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
P-R-O-C-H-Y
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
I agree with your change. There is a conflict if these headers are used and USB mode is USB-OTG (tinyusb).
// Bluetooth Libraries
#include "BLEHIDDevice.h"
// USB Libraries
#include "USB.h"
#include "USBHIDKeyboard.h"
Thanks for PR @PeterHindes
SuGlider
approved these changes
Dec 9, 2022
|
Thank you for reviewing and merging. |
DamianSuess
added a commit
to DamianSuess/EspBleLibrary
that referenced
this pull request
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Change the names of some defines. I cannot find anywhere in the library where they are used, but I decided to keep them anyway with new names. This pr is in order to fix this issue
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
It compiles, and I have used it on an esp32-s3